Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

libbpf-rs: add map freeze #248

Merged
merged 1 commit into from
Jul 28, 2022
Merged

libbpf-rs: add map freeze #248

merged 1 commit into from
Jul 28, 2022

Conversation

insearchoflosttime
Copy link
Collaborator

No description provided.

danielocfb
danielocfb reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems sensible to me. Thanks! I am just wondering whether we should add a doc comment providing more details on what the method does, as it seems to be publicly accessible by users. What do you think?

@insearchoflosttime
Copy link
Collaborator Author

insearchoflosttime commented Jul 27, 2022 •
edited
Loading

I think that's a great idea, I will update this accordingly

@insearchoflosttime
libbpf-rs: add map freeze
612430e 
Signed-off-by: Joanne Koong <joannekoong@gmail.com>
danielocfb
danielocfb approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@insearchoflosttime insearchoflosttime merged commit 445e535 into master Jul 28, 2022
@insearchoflosttime insearchoflosttime deleted the map_freeze branch July 28, 2022 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danielocfb danielocfb danielocfb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insearchoflosttime @danielocfb