libbpf-rs: Add wrapper for ringbuffer__epoll_fd #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
reviewed
Jul 28, 2022
libbpf-rs/src/ringbuf.rs
Outdated
| @@ -146,6 +146,15 @@ impl<'a> RingBuffer<'a> { | |||
|
|
|||
| util::parse_ret(ret) | |||
| } | |||
|
|
|||
| /// Get an fd that can be used to sleep until data is available | |||
| pub fn epoll_fd(&self) -> Result<()> { | |||
There was a problem hiding this comment.
Shouldn't this be returning an FD?
And does it need a Result wrapper? Doesn't the RingBuffer hold the invariant that the underlying struct ring_buffer is valid?
There was a problem hiding this comment.
The fd may be an error value if it failed to create the epoll instance (https://elixir.bootlin.com/linux/latest/source/tools/lib/bpf/ringbuf.c#L177)
There was a problem hiding this comment.
Nvm, just realized that epoll_fd will be called only when fd is valid. I'll update this commit :) thanks for catching this!
As part of the initiative to reach feature-parity with libbpf-1.0, this commit adds a wrapper for the ringbuffer__epoll_fd API.
insearchoflosttime
force-pushed
the
ringbuf_epoll_fd
branch
from
0088e86 to
eaa131d
Compare
danobi
approved these changes
Jul 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the initiative to reach feature-parity with libbpf-1.0, this
commit adds a wrapper for the ringbuffer__epoll_fd API.