Add setFilter function to configure the video's texture filtering #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonIT
reviewed
Sep 22, 2023
gradle.properties
Outdated
| @@ -14,7 +14,7 @@ gdxVersion=1.12.0 | |||
|
|
|||
| # Publishing settings | |||
| group=com.badlogicgames.gdx-video | |||
| version=1.3.2 | |||
There was a problem hiding this comment.
I don't know if increasing the version is necessary. We haven't even made a full release yet. There are only snapshots.
There was a problem hiding this comment.
Ah, right. I'll remove that change for now.
Do you think a full release will happen at some point, or do you know what's missing for that?
There was a problem hiding this comment.
I can make a full release in the next few days. I didn't make it until now because I wanted the code to get more tested and the desktop implementation wasn't that good (like you experienced)
dasisdormax
force-pushed
the
common-texture-management
branch
from
0ac7fe8 to
bfa2e84
Compare
SimonIT
approved these changes
Sep 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to the previous discussion in #77, this is a simple implementation of configuring the texture filtering of a VideoPlayer. The filter is applied to the currently active video texture and all textures that are created later.
In order to share the implementation across platforms, an abstract class
AbstractVideoPlayerwas created. If a different way to do this is better or the name should be changed (I could also imagine "VideoPlayerCommon"), I am open to suggestions.Finally, I updated the version number as there is now a default filter set that wasn't set before.