Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix frame header parsing #88

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix frame header parsing #88

merged 2 commits into from
Jan 23, 2025

Conversation

mo271
Copy link
Member

@mo271 mo271 commented Jan 8, 2025

No description provided.

@mo271
Copy link
Member Author

mo271 commented Jan 15, 2025

---- frame::test::read_frames_from_path_spline_on_first_frame stdout ----
Setting all_default to false. total_bits_read: 41, peek: 236
!all_default is true, setting frame_type to RegularFrame. total_bits_read: 43, peek: 123
!all_default is true, setting encoding to Modular. total_bits_read: 44, peek: 61
!all_default is true, setting flags to 16. total_bits_read: 50, peek: 24
!all_default && (!nonserialized.xyb_encoded) is true, setting do_ycbcr to false. total_bits_read: 51, peek: 12
!all_default && (do_ycbcr && flags & Flags::USE_LF_FRAME == 0) is false, setting jpeg_upsampling to [0, 0, 0]. total_bits_read: 51, peek: 12
!all_default && (flags & Flags::USE_LF_FRAME == 0) is true, setting upsampling to 1. total_bits_read: 53, peek: 3
!all_default && (flags & Flags::USE_LF_FRAME == 0) is true, setting ec_upsampling to []. total_bits_read: 53, peek: 3
!all_default && (encoding == Encoding::Modular) is true, setting group_size_shift to 3. total_bits_read: 55, peek: 64
!all_default && (encoding == Encoding::VarDCT && nonserialized.xyb_encoded) is false, setting x_qm_scale to 3. total_bits_read: 55, peek: 64
!all_default && (encoding == Encoding::VarDCT && nonserialized.xyb_encoded) is false, setting b_qm_scale to 2. total_bits_read: 55, peek: 64
!all_default && (frame_type != FrameType::ReferenceOnly) is true, setting passes to Passes { num_passes: 1, num_ds: 0, shift: [], downsample: [], last_pass: [] }. total_bits_read: 57, peek: 16
!all_default && (frame_type == FrameType::LFFrame) is false, setting lf_level to 0. total_bits_read: 57, peek: 16
!all_default && (frame_type != FrameType::LFFrame) is true, setting have_crop to false. total_bits_read: 58, peek: 8
!all_default && (have_crop && frame_type != FrameType::ReferenceOnly) is false, setting x0 to 0. total_bits_read: 58, peek: 8
!all_default && (have_crop && frame_type != FrameType::ReferenceOnly) is false, setting y0 to 0. total_bits_read: 58, peek: 8
!all_default && (have_crop) is false, setting frame_width to 0. total_bits_read: 58, peek: 8
!all_default && (have_crop) is false, setting frame_height to 0. total_bits_read: 58, peek: 8
!all_default && (frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) is true, setting blending_info to BlendingInfo { mode: Replace, alpha_channel: 0, clamp: false, source: 0 }. total_bits_read: 60, peek: 2
!all_default is true, setting ec_blending_info to []. total_bits_read: 60, peek: 2
!all_default && ((frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) && nonserialized.have_animation) is false, setting duration to 0. total_bits_read: 60, peek: 2
!all_default && ((frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) && nonserialized.have_timecode) is false, setting timecode to 0. total_bits_read: 60, peek: 2
!all_default && (frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) is true, setting is_last to false. total_bits_read: 61, peek: 1
!all_default && (frame_type != FrameType::LFFrame && !is_last) is true, setting save_as_reference to 1. total_bits_read: 63, peek: 0
!all_default && (false) is false, setting can_be_referenced to true. total_bits_read: 63, peek: 0
!all_default && (false) is false, setting full_frame to true. total_bits_read: 63, peek: 0
!all_default && (false) is false, setting save_before_ct_def_false to true. total_bits_read: 63, peek: 0
!all_default && (frame_type == FrameType::ReferenceOnly || save_before_ct_def_false) is true, setting save_before_ct to false. total_bits_read: 64, peek: 0
!all_default is true, setting name to "". total_bits_read: 66, peek 0
!all_default is true, setting restoration_filter to RestorationFilter { all_default: false, gab: false, gab_custom: false, gab_x_weight1: 0.115169525, gab_x_weight2: 0.061248593, gab_y_weight1: 0.115169525, gab_y_weight2: 0.061248593, gab_b_weight1: 0.115169525, gab_b_weight2: 0.061248593, epf_iters: 0, epf_sharp_custom: false, epf_sharp_lut: [0.0, 0.14285715, 0.2857143, 0.42857143, 0.5714286, 0.71428573, 0.85714287, 1.0], epf_weight_custom: false, epf_channel_scale: [40.0, 5.0, 3.5], epf_pass1_zeroflush: 0.45, epf_pass2_zeroflush: 0.6, epf_sigma_custom: false, epf_quant_mul: 0.46, epf_pass0_sigma_scale: 0.9, epf_pass2_sigma_scale: 6.5, epf_border_sad_mul: 0.6666667, epf_sigma_for_modular: 1.0, extensions: Extensions }. total_bits_read: 72, peek: 0
!all_default is true, setting extensions to Extensions. total_bits_read: 74, peek: 0
!all_default && (false) is false, setting width to 32. total_bits_read: 74, peek: 0
!all_default && (false) is false, setting height to 32. total_bits_read: 74, peek: 0
!all_default && (false) is false, setting maxhs to 0. total_bits_read: 74, peek: 0
!all_default && (false) is false, setting maxvs to 0. total_bits_read: 74, peek: 0
Setting all_default to false. total_bits_read: 329, peek: 236
!all_default is true, setting frame_type to RegularFrame. total_bits_read: 331, peek: 123
!all_default is true, setting encoding to Modular. total_bits_read: 332, peek: 61
!all_default is true, setting flags to 16. total_bits_read: 338, peek: 24
!all_default && (!nonserialized.xyb_encoded) is true, setting do_ycbcr to false. total_bits_read: 339, peek: 12
!all_default && (do_ycbcr && flags & Flags::USE_LF_FRAME == 0) is false, setting jpeg_upsampling to [0, 0, 0]. total_bits_read: 339, peek: 12
!all_default && (flags & Flags::USE_LF_FRAME == 0) is true, setting upsampling to 1. total_bits_read: 341, peek: 195
!all_default && (flags & Flags::USE_LF_FRAME == 0) is true, setting ec_upsampling to []. total_bits_read: 341, peek: 195
!all_default && (encoding == Encoding::Modular) is true, setting group_size_shift to 3. total_bits_read: 343, peek: 176
!all_default && (encoding == Encoding::VarDCT && nonserialized.xyb_encoded) is false, setting x_qm_scale to 3. total_bits_read: 343, peek: 176
!all_default && (encoding == Encoding::VarDCT && nonserialized.xyb_encoded) is false, setting b_qm_scale to 2. total_bits_read: 343, peek: 176
!all_default && (frame_type != FrameType::ReferenceOnly) is true, setting passes to Passes { num_passes: 1, num_ds: 0, shift: [], downsample: [], last_pass: [] }. total_bits_read: 345, peek: 44
!all_default && (frame_type == FrameType::LFFrame) is false, setting lf_level to 0. total_bits_read: 345, peek: 44
!all_default && (frame_type != FrameType::LFFrame) is true, setting have_crop to false. total_bits_read: 346, peek: 22
!all_default && (have_crop && frame_type != FrameType::ReferenceOnly) is false, setting x0 to 0. total_bits_read: 346, peek: 22
!all_default && (have_crop && frame_type != FrameType::ReferenceOnly) is false, setting y0 to 0. total_bits_read: 346, peek: 22
!all_default && (have_crop) is false, setting frame_width to 0. total_bits_read: 346, peek: 22
!all_default && (have_crop) is false, setting frame_height to 0. total_bits_read: 346, peek: 22
!all_default && (frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) is true, setting blending_info to BlendingInfo { mode: Blend, alpha_channel: 0, clamp: false, source: 0 }. total_bits_read: 348, peek: 5
!all_default is true, setting ec_blending_info to []. total_bits_read: 348, peek: 5
!all_default && ((frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) && nonserialized.have_animation) is false, setting duration to 0. total_bits_read: 348, peek: 5
!all_default && ((frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) && nonserialized.have_timecode) is false, setting timecode to 0. total_bits_read: 348, peek: 5
!all_default && (frame_type == FrameType::RegularFrame || frame_type == FrameType ::
SkipProgressive) is true, setting is_last to true. total_bits_read: 349, peek: 2
!all_default && (frame_type != FrameType::LFFrame && !is_last) is false, setting save_as_reference to 0. total_bits_read: 349, peek: 2
!all_default && (false) is false, setting can_be_referenced to false. total_bits_read: 349, peek: 2
!all_default && (false) is false, setting full_frame to true. total_bits_read: 349, peek: 2
!all_default && (false) is false, setting save_before_ct_def_false to false. total_bits_read: 349, peek: 2
!all_default && (frame_type == FrameType::ReferenceOnly || save_before_ct_def_false) is false, setting save_before_ct to false. total_bits_read: 349, peek: 2
!all_default is true, setting name to "\0\0\u{7} \0\u{e}¢¢bd\u{8c}\u{4}à\u{17}\0\0". total_bits_read: 484, peek 17
thread 'frame::test::read_frames_from_path_spline_on_first_frame' panicked at jxl/src/frame.rs:112:10:
called `Result::unwrap()` on an `Err` value: OutOfBounds

@mo271 mo271 marked this pull request as ready for review January 23, 2025 16:17
@mo271 mo271 requested a review from veluca93 January 23, 2025 16:17
@mo271 mo271 changed the title two more test images fix frame header parsing Jan 23, 2025
@mo271 mo271 merged commit 72a010e into libjxl:main Jan 23, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants