Fixed wrong script dir location for flash targets #157
Conversation
|
You're right, some of this is some old stubs that aren't used much, carried over from when this was part of the main repo. It's proven difficult to maintain all the duplicated bits of makefile for this sort of stuff. |
examples/rules.mk
Outdated
| @@ -92,7 +92,8 @@ endif | |||
| include $(OPENCM3_DIR)/mk/genlink-config.mk | |||
| endif | |||
|
|
|||
| SCRIPT_DIR = $(OPENCM3_DIR)/scripts | |||
| OPENCM3_SCRIPT_DIR = $(OPENCM3_DIR)/scripts | |||
| EXAMPLES_SCRIPT_DIR = $(OPENCM3_DIR)../scripts | |||
There was a problem hiding this comment.
in one of them, you use an intermediate, /, but not the otther, is this really intentional?
There was a problem hiding this comment.
tried to avoid the double // in the path, but they're all over the file anyway. Updated to double //
|
should the refs to |
|
I'd be totally fine with just dropping support for that flashing method enttirely, it clearly hasn't worked for a very long time, and required make vars to be set to even try. |
|
Removed the references to the script, any other changes needed? |
|
merged in 2107faf and predecessor tahnks! |
This PR tries to fix some of #34
It seems like there are 2 script dirs, one in the examples and one in the library itself. The scripts for the BMP are in the examples/scripts dir, not the library one.
I can't seem to find the
stlink_flash.scrscript anywhere though :/