Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

fix: get remoteID from pb message in plaintext #52

Merged
merged 1 commit into from
Jan 11, 2020
Merged

fix: get remoteID from pb message in plaintext #52

merged 1 commit into from
Jan 11, 2020

Conversation

mhchia
Copy link
Contributor

@mhchia mhchia commented Aug 23, 2019 •
edited
Loading

Instead of calculated from the public key. Otherwise,

remoteID.MatchesPublicKey(remotePubkey)

is always True.

@mhchia mhchia changed the title Get remoteID from pb message fix: get remoteID from pb message in plaintext Aug 23, 2019
@Stebalien Stebalien requested a review from yusefnapora December 7, 2019 02:52
yusefnapora
yusefnapora approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry about the delay reviewing :)

@Stebalien Stebalien merged commit 0ad6b1c into libp2p:master Jan 11, 2020
@mhchia mhchia deleted the patch-1 branch January 11, 2020 08:58
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 24, 2020
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhchia @yusefnapora @Stebalien