Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Forbid small RSA keys #42

Closed
Stebalien opened this issue Sep 28, 2018 · 0 comments · Fixed by #43
Closed

Forbid small RSA keys #42

Stebalien opened this issue Sep 28, 2018 · 0 comments · Fixed by #43
Assignees
@Stebalien

Comments

@Stebalien
Copy link
Member

RSA keys can't be smaller than 512 bytes (otherwise, signing simply won't work).

Ideally, we should:

  1. Forbid keys smaller than 2048 by default (for security reasons).
  2. Provide a testing option to lower this minimum.
  3. Set a hard limit at 512 as things simply stop working below that (we can't sign a 256bit hash with a 256bit key).
Stebalien added a commit that referenced this issue Sep 28, 2018
@Stebalien
forbid RSA keys smaller than 512 bits
27541cc 
We do use small keys for testing but keys smaller than this are entirely useless
as we need to be able to sign 256bit hashes.

fixes #42
@Stebalien Stebalien mentioned this issue Sep 28, 2018
Merged
@ghost ghost assigned Stebalien Sep 28, 2018
@ghost ghost added the in progress label Sep 28, 2018
Stebalien added a commit that referenced this issue Sep 28, 2018
@Stebalien
forbid RSA keys smaller than 512 bits
4b040bd 
We do use small keys for testing but keys smaller than this are entirely useless
as we need to be able to sign 256bit hashes.

fixes #42
@ghost ghost removed the in progress label Sep 28, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

forbid RSA keys smaller than 512 bits libp2p/go-libp2p-crypto
1 participant
@Stebalien