This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
feat: refactor key interface #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now allows full access to the raw bytes of all keys and unifies pb marshals cc @Stebalien
ghost
assigned 
Stebalien
reviewed
Jul 18, 2018
ed25519.go
Outdated
| pbmes.Type = &typ | ||
| pbmes.Data = (*k.k)[:] | ||
| return proto.Marshal(pbmes) | ||
| func (sk *Ed25519PublicKey) Type() pb.KeyType { |
There was a problem hiding this comment.
Should use k as the receiver.
key.go
Outdated
| Bytes() ([]byte, error) | ||
|
|
||
| // Equals checks whether two PubKeys are the same | ||
| Equals(Key) bool | ||
|
|
||
| // Raw returns the raw bytes of the key. | ||
| Raw() ([]byte, error) |
There was a problem hiding this comment.
Note that this is the inverse of the {Pub,Priv}KeyUnmarshaler.
Stebalien
approved these changes
Jul 25, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now allows full access to the raw bytes of all keys and unifies pb marshals
RawTypeBytescc @Stebalien