Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Problem with running a dns only dht #973

Closed
sukunrt opened this issue Jul 4, 2024 · 2 comments · Fixed by #1041
Closed

Problem with running a dns only dht #973

sukunrt opened this issue Jul 4, 2024 · 2 comments · Fixed by #1041
Assignees

Comments

@sukunrt
Copy link
Member

sukunrt commented Jul 4, 2024

When running a dht node which advertises only /dns addresses, I see that my node is not getting any incoming connections and the outgoing connections are eventually closed as well, leading to a situation where the node has < 10 connections.

This happens because this change: #839 which added a filter for incoming addresses.
Similarly go-libp2p added a filter for addresses in identify here: libp2p/go-libp2p#2300

While both these changes are correct they relied on an incorrect version of manet.IsPublic which incorrectly classified /dns addresses as non Public. This was eventually fixed in go-libp2p and go-multiaddr by: https://github.com/libp2p/go-libp2p/pull/2553/files

There are still a lot of nodes out there on the incorrect version which is leading to /dns addresses being filtered.

  1. We should add a test somewhere in this repo to prevent a regression.
  2. Mention somewhere that at least on the Amino DHT, people will have to advertise their IP addresses.
@guillaumemichel guillaumemichel self-assigned this Jul 4, 2024
@lidel lidel moved this to In Progress in @lidel's IPFS wishlist Jul 9, 2024
@guillaumemichel guillaumemichel removed their assignment Jan 7, 2025
@guillaumemichel guillaumemichel self-assigned this Jan 14, 2025
@lidel
Copy link
Member

lidel commented Jan 14, 2025

Triage note:

  • @guillaumemichel will check how prevalent use case of "/dns"-only DHT servers is on public mainnet
  • decide priority based on that

@guillaumemichel
Copy link
Contributor

In the last 24h, 80 distinct peers advertising dns multiaddrs only (not /ipX/ addrs) have been detected by the Nebula Crawler.

I will take care of writing the regression test.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants