Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: cover dns addresses in TestAddrFilter #1041

Merged
merged 1 commit into from
Feb 20, 2025
Merged

test: cover dns addresses in TestAddrFilter #1041

merged 1 commit into from
Feb 20, 2025

Conversation

guillaumemichel
Copy link
Contributor

Fixes #973

Adding test coverage for /dns, /dns4, /dns6 and /dnsaddr addresses in TestAddrFilter.

@guillaumemichel guillaumemichel requested a review from a team as a code owner February 20, 2025 10:42
sukunrt
sukunrt approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me.
For some prior discussion here, see: multiformats/go-multiaddr#220

@guillaumemichel guillaumemichel merged commit 79eaf41 into master Feb 20, 2025
7 checks passed
@guillaumemichel guillaumemichel deleted the tests/dns-addresses branch February 20, 2025 10:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with running a dns only dht
2 participants
@guillaumemichel @sukunrt