chore: update deps #1044
Closed
chore: update deps #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
force-pushed
the
deps-20250220
branch
from
99e1787 to
9b6d017
Compare
MarcoPolo
requested changes
Feb 20, 2025
There was a problem hiding this comment.
I'd like to understand why QUIC is causing flakiness here first. Let's investigate that first, then decide if we want to disable it (but I'd lean towards no without a compelling reason).
With QUIC we can mock a lot of the network in a better way than we can with the TCP transport. See this PR as an example of using a simulated connection to test holepunching: libp2p/go-libp2p#3044. Maybe that simulated connection code could be useful for debugging here?
|
After deeper investigation, the problem seemed to be linked to the go version used by the CI. Fixed in #1048 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am disabling QUIC for tests since some tests are randomly timing out in the CI (they are fine when run locally) when QUIC is enabled (some peers time out when connecting to each other). Everything was fine with
quic-go v0.48.2but something seems to have broken inquic-go v0.49.0on whichgo-libp2p v0.40.0depends.IMO it is fine to disable QUIC from the DHT tests since the goal is to test the DHT behaviour and not the transports.
@libp2p/go-libp2p-maintainers @marten-seemann