Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add go mod turds and CI test #230

Closed
wants to merge 3 commits into from
Closed

Add go mod turds and CI test #230

wants to merge 3 commits into from

Conversation

anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Jan 24, 2019 •
edited
Loading

Adds go module turds, and a CI test to ensure they work.

@ghost ghost assigned anacrolix Jan 24, 2019
@ghost ghost added the status/in-progress In progress label Jan 24, 2019
@anacrolix
Reduce aggressive test
ec00828 
Doesn't pass in time with race detector enabled.
@anacrolix
Add go mod CI test
4c5cd66
@anacrolix anacrolix changed the title Add go turd files Add go mod turds and CI test Jan 25, 2019
@anacrolix anacrolix requested a review from raulk January 25, 2019 01:12
raulk
raulk reviewed Jan 28, 2019
View reviewed changes
lanzafame
lanzafame reviewed Jan 28, 2019
View reviewed changes
@anacrolix anacrolix mentioned this pull request Jan 29, 2019
Merged
@anacrolix
Copy link
Contributor Author

@raulk @lanzafame This is ready for approval.

@anacrolix
Copy link
Contributor Author

If #236 is merged, I'll rejig this to include only the CI.

@anacrolix anacrolix mentioned this pull request Jan 30, 2019
Merged
@anacrolix
Copy link
Contributor Author

Superceded by #238 and #236

@anacrolix anacrolix closed this Jan 30, 2019
@ghost ghost removed the status/in-progress In progress label Jan 30, 2019
@anacrolix anacrolix deleted the go-turds branch January 30, 2019 23:23
@anacrolix anacrolix restored the go-turds branch February 7, 2019 01:34
@anacrolix anacrolix reopened this Feb 7, 2019
@ghost ghost added the status/in-progress In progress label Feb 7, 2019
@anacrolix anacrolix closed this Feb 7, 2019
@ghost ghost removed the status/in-progress In progress label Feb 7, 2019
@anacrolix anacrolix deleted the go-turds branch February 7, 2019 01:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@raulk raulk raulk left review comments

@lanzafame lanzafame lanzafame left review comments

Assignees

@anacrolix anacrolix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anacrolix @raulk @lanzafame