Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix nonsensical check #154

Merged
merged 1 commit into from
Jan 20, 2019
Merged

fix nonsensical check #154

merged 1 commit into from
Jan 20, 2019

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Jan 20, 2019

Fixes #153

@ghost ghost assigned vyzo Jan 20, 2019
@ghost ghost added the in progress label Jan 20, 2019
@vyzo vyzo mentioned this pull request Jan 20, 2019
Closed
@paralin
Copy link

paralin commented Jan 20, 2019

I don't want to sound pedantic, but I'd also recommend adopting a more formal commit message style (see Angular 2's commit style or the Linux kernel commit style) just because it makes peer reviewing much easier.

@vyzo
Copy link
Collaborator Author

vyzo commented Jan 20, 2019

well, that was a brainfart, so i called it as such :p
but ok, i'll call it something else if it offends your sensibilities.

@vyzo vyzo merged commit ef065c2 into master Jan 20, 2019
@vyzo vyzo deleted the fix/issue-153 branch January 20, 2019 22:26
@ghost ghost removed the in progress label Jan 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@vyzo vyzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @paralin