Gossipsub: Unsubscribe backoff #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Jun 2, 2022
gossipsub.go
Outdated
| // backoff? (instead of always the prune backoff). Aren't we trying | ||
| // to figure out the original prune time (expires - backoff), then | ||
| // figure out the flood cutoff ((expires - backoff) + floodThreshold)? | ||
| // Rust always uses PruneBackoff here. (and I'm not sure if nim handles this: https://github.com/status-im/nim-libp2p/blob/3fdbac49cc5a167673a2bc4b9e1c4b11ca307396/libp2p/protocols/pubsub/gossipsub/behavior.nim#L134 |
There was a problem hiding this comment.
this should be prune backoff, we are not unsubscribing, we are pruning.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements libp2p/specs#383. There's an open question left in a comment here.