Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sync: update CI config files (and fix tests) #1083

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Conversation

Stebalien
Copy link
Member

Reverted #1082 because this really should have a review.

web3-bot and others added 7 commits April 29, 2021 21:35
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was mostly test cleanup, which LGTM. I see we're using a bunch of sleeps in tests, which makes me a bit sad, but that's not the fault of this PR.

@Stebalien Stebalien merged commit 4ca9ecd into master Apr 30, 2021
@Stebalien Stebalien deleted the web3-bot/sync branch April 30, 2021 17:35
@Stebalien
Copy link
Member Author

Yeah, I'd love to reduce the sleeps....

@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants