expose the security protocol on the ConnectionState #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a subset of the transports use the ugprader (which uses the SSMuxer). It's better to perform this check for every transport.
MarcoPolo
approved these changes
Nov 21, 2022
| @@ -89,9 +92,14 @@ func New(secureMuxer sec.SecureMuxer, muxers []StreamMuxer, psk ipnet.PSK, rcmgr | |||
| } | |||
| u.muxerIDs = make([]string, 0, len(muxers)) | |||
| for _, m := range muxers { | |||
| u.msmuxer.AddHandler(string(m.ID), nil) | |||
| u.muxerMuxer.AddHandler(string(m.ID), nil) | |||
There was a problem hiding this comment.
Future refactor: We can have the mulstreamMuxer accept a generic for the Handler then we can a reference to the muxer/security upgrader directly in the multistream muxer instead of passing nil here, then having to get the reference ourselves: https://github.com/libp2p/go-libp2p/pull/1907/files#diff-bac06b53f2856923e32085b096994a99dd77a67ce02a3ff4cb64d3610c2345fdR301
| // The stream multiplexer used on this connection (if any). | ||
| StreamMultiplexer string | ||
| // The security protocol used on this connection (if any). | ||
| Security string |
There was a problem hiding this comment.
💯 Thanks for this rename. I think this makes a lot more sense.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the integration test needed for #1906. Will also be needed to report swarm metrics (#1356).