Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

swarm: return a more meaningful error when dialing QUIC draft-29 #2524

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@marten-seemann marten-seemann linked an issue Aug 25, 2023 that may be closed by this pull request
Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
@marten-seemann
Copy link
Contributor Author

Nice one, thanks @Jorropo!

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you need to go fmt since I used space instead of tabs in my suggestion.
Thx

@Jorropo
Copy link
Contributor

Jorropo commented Aug 25, 2023

Also ErrQUICDraft29 (type) is not an expression, up to you, you could do that instead:

var ErrQUICDraft29 errQUICDraft29

type errQUICDraft29 struct{}

@marten-seemann marten-seemann merged commit 4caa4e5 into master Aug 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when trying to dial /quic peer
3 participants