fix(holepunch/tracer): replace inline peer struct with peerInfo type #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced the `peerInfo` struct to encapsulate peer metadata. - Updated the `peers` map in the `tracer` struct to use `peerInfo`. - Simplified code by avoiding inline struct definition for peers.
MarcoPolo
approved these changes
Nov 19, 2024
MarcoPolo
changed the title
MarcoPolo
changed the title
|
thanks! |
ethan-gallant
added a commit
to ethan-gallant/go-libp2p
that referenced
this pull request
Dec 16, 2024
…fo type (libp2p#3049)" This reverts commit cb14acf.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peerInfostruct to encapsulate peer metadata.peersmap in thetracerstruct to usepeerInfo.