feat: allow passing options to memoryAddrBook #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
changed the title
2color
changed the title
|
Can't you just use it like libp2p/go-libp2p-pubsub#555 does? By assuming the return value is an |
I did. If you look at the latest version of this PR, it solely adds the ability pass in options without using the PeerBook. |
sukunrt
approved these changes
Nov 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I'm adding an instance of the
MemoryAddrBookto someguy to manage peer record caching/ttls locally in a similar fashion to libp2p/go-libp2p-pubsub#555.That requires passing passing options and using it without a PeerStore. For that being able to pass options is handy.
This PR also fixes the defaults in the factory.