when we do a nat port mapping, explicitly remember the mapped address #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #383 I won't call this *fixed* yet but it should help.
ghost
assigned 
Stebalien
added a commit
that referenced
this pull request
Aug 13, 2018
This reverts commit aca83b9, reversing changes made to 86b8929. This was is not the correct fix. We already expose these addresses via the host's AllAddrs method. The real problem is probably that we just don't ever tell anyone about them (unless we disconnect and reconnect to our nearby DHT nodes). We need an address gossip protocol.
Stebalien
added a commit
that referenced
this pull request
Aug 16, 2018
Revert "Merge pull request #386 from libp2p/fix/correct-external-addr"
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #383
I won't call this fixed yet but it should help.