Add delay in initial relay advertisement to allow the dht time to bootstrap #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
bigs
suggested changes
Dec 4, 2018
p2p/host/relay/relay.go
Outdated
| @@ -25,7 +30,10 @@ func NewRelayHost(ctx context.Context, bhost *basic.BasicHost, advertise discove | |||
| advertise: advertise, | |||
| } | |||
| bhost.AddrsFactory = h.hostAddrs | |||
| discovery.Advertise(ctx, advertise, RelayRendezvous) | |||
| go func() { | |||
| time.Sleep(AdvertiseBootDelay) | |||
There was a problem hiding this comment.
select {
case <-time.After(AdvertiseBootDelay):
discovery.Advertise(ctx, advertise, RelayRendezvous)
case <-ctx.Done():
}
|
@bigs done. |
bigs
approved these changes
Dec 5, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in libp2p/go-libp2p-discovery#5
Also increases the test autonat identify delay to 500ms to make it less flaky in macos.