Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove the sendLock in the stream #41

Merged
merged 1 commit into from
Feb 17, 2021
Merged

remove the sendLock in the stream #41

merged 1 commit into from
Feb 17, 2021

Conversation

marten-seemann
Copy link
Contributor

Concurrent use of an io.Writer is not valid.

@marten-seemann
remove the sendLock in the stream
f2c2ce6 
Concurrent use of an io.Writer is not valid.
Stebalien
Stebalien approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need to carefully run some go-ipfs tests to make sure this doesn't break any assumptions..., but it really shouldn't.

@marten-seemann marten-seemann merged commit 4e665e8 into master Feb 17, 2021
@marten-seemann marten-seemann deleted the remove-send-lock branch February 17, 2021 02:00
@Stebalien Stebalien mentioned this pull request May 11, 2021
Closed
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien