Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PeerInfo required in config but not in README #219

Closed
cretz opened this issue Jul 9, 2018 · 1 comment
Closed

PeerInfo required in config but not in README #219

cretz opened this issue Jul 9, 2018 · 1 comment

Comments

@cretz
Copy link

cretz commented Jul 9, 2018

At

peerInfo: Joi.object().required(),
it has peer info required, but in the README it says "peerInfo: instance of PeerInfo that contains the PeerId, Keys and multiaddrs of the libp2p Node. Optional.". I would just like to be a client to the DHT to lookup providers so I think, like the Go impl, you shouldn't need peer info for it but I don't know enough details about the DHT impl to know.

@jacobheun
Copy link
Contributor

Fixed by #236 readme update.

maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
* deps(dev): bump aegir from 37.12.1 to 38.1.7

Bumps [aegir](https://github.com/ipfs/aegir) from 37.12.1 to 38.1.7.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v37.12.1...v38.1.7)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: fix upgrade

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
## [5.0.5](libp2p/js-libp2p-websockets@v5.0.4...v5.0.5) (2023-03-09)

### Trivial Changes

* Update .github/workflows/semantic-pull-request.yml [skip ci] ([4936a70](libp2p/js-libp2p-websockets@4936a70))

### Dependencies

* **dev:** bump @libp2p/interface-mocks from 8.0.5 to 9.1.3 ([libp2p#220](libp2p/js-libp2p-websockets#220)) ([1076b05](libp2p/js-libp2p-websockets@1076b05))
* **dev:** bump aegir from 37.12.1 to 38.1.7 ([libp2p#219](libp2p/js-libp2p-websockets#219)) ([4e0f17b](libp2p/js-libp2p-websockets@4e0f17b))
achingbrain added a commit that referenced this issue Jun 27, 2023
achingbrain pushed a commit that referenced this issue Jun 27, 2023
## [7.0.0](libp2p/js-libp2p-floodsub@v6.0.3...v7.0.0) (2023-04-18)

### ⚠ BREAKING CHANGES

* update stream types (#219)

### Dependencies

* update stream types ([#219](libp2p/js-libp2p-floodsub#219)) ([7b95773](libp2p/js-libp2p-floodsub@7b95773))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants