Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove uses of pin_project::project attribute #1604

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jun 5, 2020

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225

Although the deprecation of the project attribute has not been released yet, this PR is submitted in advance to avoid the CI from being broken by deprecated warnings.

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taiki-e for updating all the crates using pin-project!

@mxinden mxinden merged commit 9aaf042 into libp2p:master Jun 9, 2020
@taiki-e taiki-e deleted the pin-project branch June 9, 2020 20:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants