Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(perf): don't use OutboundOpenInfo #3763

Merged
merged 4 commits into from
Apr 28, 2023
Merged

refactor(perf): don't use OutboundOpenInfo #3763

merged 4 commits into from
Apr 28, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Instead of passing the command along, we store it in a buffer and retrieve it once the stream is upgraded.

Related: #3268.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden April 10, 2023 17:55
@thomaseizinger thomaseizinger mentioned this pull request Apr 11, 2023
Closed
@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Apr 28, 2023
@mergify mergify bot merged commit 8445079 into master Apr 28, 2023
@mergify mergify bot deleted the refactor/3268-perf branch April 28, 2023 11:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaseizinger