Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(relay): remove explicit stream tracking #4744

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

With #4306 resolved, we no longer need to carry around oneshots in the relay code that track our alive streams. This is now handled directly by Connection.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Happy for this to be deleted.

@mergify mergify bot merged commit 35a92df into master Oct 30, 2023
@mergify mergify bot deleted the refactor/relay-no-stream-counting branch October 30, 2023 10:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants