Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

OID duplicated - wrong value for SHA1_RSA #67

Closed
ChrisGreenaway opened this issue Jan 28, 2022 · 1 comment · Fixed by #122 or #128
Closed

OID duplicated - wrong value for SHA1_RSA #67

ChrisGreenaway opened this issue Jan 28, 2022 · 1 comment · Fixed by #122 or #128

Comments

@ChrisGreenaway
Copy link
Contributor

OID for SHA1 looks wrong:

ISO_MEMBER_BODY_US_RSADSI_PKCS1_MD5_RSA => 1, 2, 840, 113549, 1, 1, 4;
ISO_MEMBER_BODY_US_RSADSI_PKCS1_SHA1_RSA => 1, 2, 840, 113549, 1, 1, 4;

SHA1 with RSA should be 1.2.840.113549.1.1.5.
@XAMPPRocky
Copy link
Collaborator

Thank you for your issue! Feel free to open a PR fixing that typo :)

ChrisGreenaway added a commit to ChrisGreenaway/rasn that referenced this issue Jan 31, 2022
@ChrisGreenaway
Fixes librasn#67. Fix SHA1_RSA OID typo and add RSAES_OAEP OID
54fffc5
This was referenced Jul 11, 2023
Merged
Closed
This was referenced Jul 26, 2023
Closed
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@XAMPPRocky @ChrisGreenaway