Improves BER GeneralizedTime decoders, support for CER/DER strict mode #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicceboy
force-pushed
the
ber-generalized-time
branch
2 times, most recently
from
c645e69 to
82c87b9
Compare
Nicceboy
force-pushed
the
ber-generalized-time
branch
from
82c87b9 to
66d6366
Compare
|
Thank you for your PR!
Yes, let's make that a follow-up PR though. |
Closed
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BER GeneralizedTime decoder should now handle all cases.
Added stricter function also for CER/DER.
I am not sure, if we should use BER decoder for CER/DER as well, but at least asn1tools use stricter versions.
Resolves #57
Also Encoder produces valid canonical form now.
Make these functions public, so that other codecs can access them.
Since BER allows any ASN.1 compatible GeneralizedTime type, should this check to be moved into the type itself?