Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

flycast: Enable RPi5 #1941

Merged
merged 2 commits into from
Mar 11, 2024
Merged

flycast: Enable RPi5 #1941

merged 2 commits into from
Mar 11, 2024

Conversation

ShigeakiAsai
Copy link
Contributor

@ShigeakiAsai ShigeakiAsai commented Mar 10, 2024

This pull request enables flycast core on RPi5

It works by following 2 changing.

  • Enable GLES3 on RPi5.
  • Temporary fix "PAGE_SIZE" issue on RPi5. (fix typo 'Temporary')

modified : 1 files , added : 1 file

  1. packages/lakka/libretro_cores/flycast/package.mk
    Enable GLES3 on RPi5.

  2. projects/RPi/devices/RPi5/patches/flycast/0001-define-pagesize.patch
    In Case of RPi5, it changes "PAGE_SIZE" value from 4096 to 16384.
    This modification is for flycast GitHub issue #1288.
    And, it also has relationship flycast GitHub commit "linux: retrieve page size at build time".
    In this commit, "Will not work if cross-compiling however" is written.
    If the cross-compiling issue will be fixed in upstream, this patch file may be unnecessary.


Confirmation

  • [RPi5]
    PAGE_SIZE : OK (#define PAGE_SIZE 16384) It is patched on source file.
    GLES3 : OK (-DUSE_GLES=ON) It confirm on build log.
  • [RPi4]
    PAGE_SIZE : OK (#define PAGE_SIZE 4096) It is No patched on source file.
    GLES3 : OK (-DUSE_GLES=ON) It confirm on build log.
  • [RPi4-GPICase2]
    PAGE_SIZE : OK (#define PAGE_SIZE 4096) It is No patched on source file.
    GLES3 : OK (-DUSE_GLES=ON) It confirm on build log.

P.S.
@gouchi
Thank you for your advice!

Thanks.
ASAI, Shigeaki

@ShigeakiAsai ShigeakiAsai marked this pull request as ready for review March 10, 2024 01:19
@Ntemis Ntemis merged commit f7bbd76 into libretro:Lakka-v5.x Mar 11, 2024
@ShigeakiAsai
Copy link
Contributor Author

I confirmed that flycast core is working on RPI5 with Lakka-RPi5.aarch64-devbuild-v5.x-20240312-4eb7275.img.gz

Thanks
ASAI, Shigeaki

@ShigeakiAsai ShigeakiAsai deleted the flycast-RPi5 branch March 14, 2024 13:31
ShigeakiAsai added a commit to ShigeakiAsai/Lakka-LibreELEC that referenced this pull request Mar 17, 2024
* Fix flyfast for RPi5

* Patch file name change and package.mk settings for RPi5 change
ToKe79 pushed a commit that referenced this pull request Apr 10, 2024
* Fix flyfast for RPi5

* Patch file name change and package.mk settings for RPi5 change
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants