Skip to content

deprecate old macros, deprecate mp_rand_digit #245

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

minad
Copy link
Member

@minad minad commented May 9, 2019

Some first deprecations in the public API. Desired? See also #243

@minad minad requested a review from sjaeckel May 9, 2019 02:12
@minad minad mentioned this pull request May 9, 2019
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if mp_rand_digit() should be deprecated but the rest LGTM

@minad
Copy link
Member Author

minad commented May 9, 2019

I think mp_digit exposure in the public api should be reduced - mp_digit should be seen more as a implementation detail, since it varies greatly depending on the target platform (8, 16, 28, 31, 32, 60 bits etc).

mp_rand_digit is one such function which works with mp_digit and therefore a candidate for deprecation. I added it here since I think it probably doesn't have many consumer under the library users.

Also note: The way I am proposing regarding deprecations always allows us to go back if many downstream users come and tell us that we deprecated something they needed. Just undeprecate and move on in that case instead of removing the deprecated api.

@sjaeckel sjaeckel merged commit d4c5fbf into develop May 10, 2019
@sjaeckel sjaeckel deleted the deprecations branch May 10, 2019 22:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants