Skip to content

Repairs and clean-ups regarding tuning and profiling #581

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Repairs and clean-ups regarding tuning and profiling #581

wants to merge 1 commit into from

Conversation

czurnieden
Copy link
Contributor

  • added tuning and graphics to cmake
  • removed RTDSC based timers
  • gnuplot generated plots via tune_it.sh
  • tuning is available in makefile.shared now

@czurnieden
Copy link
Contributor Author

Changes from the additional tuning are small but YMMV, as always.

@czurnieden czurnieden requested a review from sjaeckel June 16, 2024 02:03
@czurnieden
Copy link
Contributor Author

CMake is a bit more complicated once it gets a bit more complicated *sigh*

@czurnieden
Copy link
Contributor Author

Ah, forgot: cannot check if the windows part works. Will somebody who can take a look, please?

@czurnieden
Copy link
Contributor Author

Well…
I posted at stackoverflow although I doubt it.

But I found a working CMake formatter so my search wasn't a complete waste ;-)

@czurnieden
- added tuning and graphics to cmake
6fa425e 
 - replaced RTDSC timers with a more standard one
 - made gnuplot generated plots available via tune_it.sh
 - moved timing points in tune.c to avoid elimination by
   optimization
@czurnieden czurnieden force-pushed the more_tuning_and_profiling branch from ae98866 to 6fa425e Compare July 1, 2024 22:40
@czurnieden
Copy link
Contributor Author

Rewound the CMake part (including the formatting, sorry) and collapsed the commits.

I think I found the problem with the odd results in tuning. We use "-O3" for tuning for a good reason but it has a side effect. With checks included (option -c for tune.c) the numbers are all reasonable, especially the first higher T-C-squarings after TC-3 that was really off. Not switched on here–nothing higher than TC-3–but put in this comment such that I do not forget it later.

@czurnieden
Copy link
Contributor Author

Timer works with MSVC, at least in Godbolt's Compiler Explorer, I just couldn't get it work under Wine. Probably too old.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjaeckel sjaeckel Awaiting requested review from sjaeckel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@czurnieden