Reorder middlewares #294
Merged
Reorder middlewares #294
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
approved these changes
Dec 11, 2024
hweawer
added a commit
that referenced
this pull request
Dec 11, 2024
* Examples of alerts * Remove special forks annotations (#271) * Remove special forks annotations * take addresses from envs * Add env * Variables in README * Move to other section * Holesky only * fix check balance test * Actualize readme * remove deprecated entrypoints * Add account label to balance * fix xfail unit tests * Update minor deps + remove package-mode * add balance check * remove tests * Remove mellow * Remove test * Fix test * Refactor strategy * Update alerts * Empty whitelist (#282) * Empty whitelist * Change default * Refactor --------- Co-authored-by: Kirill <infloop.gm@gmail.com> Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Track recommended fee despite checks (#281) * Fetch prefix one time for a batch (#279) * Fetch prefix one time * default arg * function arg * Filters on request * Fix tests * refactor * Fix unvetter tests * Fix bug * fix signatures in test * Fix * Fix * Fix * Fix * Fix comments * Gas strategy with addendum (#285) * Gas strategy with addendum * Precommit hooks * Env variable * Update README * Gwei default * Module iteration until first healthy module (#286) * Cache quorum * Gather quorum in advance * Update tests * Fix types * fix var * fix * Fix comments * Fix sorting * Remove unit tests * Move minutes to a variable * Add more logs * Unit tests for iteration order * Comment * Fix comments * Update curl (#287) * Update curl * Pin version * Update aiohttp (#289) * Max operators per unvetting check (#290) * Max operators per unvetting check * Upgrade test * Cache chain-id (#288) * Cache chain-id * middleware to cache id * Cache gnosis * Add metrics to gnosis * Remove i * Fix recursion (#292) * Fix recursion * Remove metrics from onchain web3 * Reorder middlewares (#294) --------- Co-authored-by: F4ever <raman.s@lido.fi> Co-authored-by: Kirill <infloop.gm@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The problem now is that despite requests are cached the metrics are still showing that requests has happened.
Why
We want not to report cached responses in requests metrics.
How
So the order of the inject matters with web3 middlewares. When we inject middlewares with
level = 0we always append to the end of the queue of middlewares. So to fail fast with cache middleware we need it to be injected first to achieve order:[..., cache middleware, other middlewares which we shouldn't reach after cache]