Fix sorting in MachO::Binary::extend_section, rework extend_section tests #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As demonstrated by @lebr0nli in the sample `ELF/issue_dynamic_table.elf`, the PT_DYNAMIC segment can have an "invalid" offset while still running correctly. This commit changes the logic of the dynamic table processing by using the PT_LOAD segment that wraps this table
If there are empty sections and non-empty section at the same offset, we want to shift only empty sections. The expected behavior is that we sort sections in ascending order, and then `sections_to_shift` is trimmed, such that the last element becomes `section`. Previously, we were sorting in descending order, while keeping empty sections in the same order. Due to this we were doing trimming incorrectly.
The previous implementation of the test was expecting unsupported behavior from LIEF. LIEF currently does not support arbitrary calls to add_section and extend_section and keeping the layout of the binary correct. Currently it is responsibility of a user to ensure that the final layout of the binary is well-formed. This patch splits test into two cases: 1. Repeated calls to add_section followed by extend_section using different alignment values. 2. Multiple calls to add_section and then multiple calls to extend_section using the same alignment values.
|
Thank you! I manually merged the PR through 60de925 (because of a force push) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.