Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use watcher addon api instead of promise to wait for generated files #4

Closed
lifeart opened this issue May 10, 2020 · 0 comments
Closed

Use watcher addon api instead of promise to wait for generated files #4

lifeart opened this issue May 10, 2020 · 0 comments
Assignees
@lifeart
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lifeart
Copy link
Owner

lifeart commented May 10, 2020 •
edited
Loading

els-component-extraction-addon/index.js

Line 52 in 96dc0e9

await new Promise((resolve) => setTimeout(resolve, 2000)); 

type Watcher = (uri: string, change: FileChangeType) => any;
project.addWatcher(fn: Watcher);

we need to wait for watcher called with expected paths with some reasonable timeout (5s)

see lifeart/ember-language-server#12
@lifeart lifeart added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 10, 2020
lifeart added a commit that referenced this issue May 13, 2020
@lifeart
feat #4
79cdf26
@lifeart lifeart self-assigned this May 13, 2020
lifeart added a commit that referenced this issue May 16, 2020
@lifeart
Merge pull request #6 from lifeart/feat-use-waiter-addon-api
99b138a 
feat #4
@lifeart lifeart closed this as completed May 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@lifeart lifeart

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lifeart