Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for multinamespaced components #212

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 1, 2021

allow us to have autocomplete for components with same name, located in different namespaces

if [addon-foo has bar component] & [addon-boo has bar component] -> we show Foo$Bar + Boo$Bar instead of only one thing

lifeart added 3 commits April 1, 2021 22:22
allow us have autocomplete for components with same name, located in different namespaces
@lifeart lifeart requested a review from suchitadoshi1987 April 1, 2021 19:33
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #212 (224ea21) into component-context-info-origin (8082482) will decrease coverage by 4.20%.
The diff coverage is 60.88%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #212      +/-   ##
=================================================================
- Coverage                          71.63%   67.42%   -4.21%     
=================================================================
  Files                                 17       38      +21     
  Lines                                913     3150    +2237     
  Branches                             180      655     +475     
=================================================================
+ Hits                                 654     2124    +1470     
- Misses                               259     1023     +764     
- Partials                               0        3       +3     
Impacted Files Coverage Δ
src/reference-provider/entry.ts 90.00% <ø> (ø)
...addons/core/code-actions/template-lint-comments.ts 10.76% <10.76%> (ø)
src/utils/usages-api.ts 29.26% <13.04%> (-70.74%) ⬇️
.../builtin-addons/core/script-completion-provider.ts 40.27% <14.28%> (ø)
...in-addons/core/code-actions/template-lint-fixes.ts 15.00% <15.00%> (ø)
...ddons/core/code-actions/typed-template-comments.ts 15.15% <15.15%> (ø)
src/builtin-addons/core/code-actions/base.ts 20.93% <20.93%> (ø)
src/code-action-provider/entry.ts 33.33% <33.33%> (ø)
src/estree-utils.ts 76.19% <33.33%> (-23.81%) ⬇️
src/glimmer-utils.ts 42.93% <41.30%> (-38.40%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580973b...224ea21. Read the comment docs.

@lifeart lifeart changed the title Add support for multinamespaced components feat: add support for multinamespaced components Apr 1, 2021
@lifeart lifeart merged commit 6b03c83 into component-context-info-origin Apr 1, 2021
@lifeart lifeart deleted the add-support-for-multinamespaced-components branch April 1, 2021 20:23
lifeart pushed a commit that referenced this pull request Apr 1, 2021
# [1.3.0](v1.2.0...v1.3.0) (2021-04-01)

### Features

* add support for multinamespaced components ([#212](#212)) ([6b03c83](6b03c83))
suchitadoshi1987 pushed a commit to suchitadoshi1987/ember-language-server that referenced this pull request Feb 9, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-02-09)

### Bug Fixes

* update debounce implementation ([lifeart#250](https://github.com/suchitadoshi1987/ember-language-server/issues/250)) ([4675e19](4675e19))

### Features

* ability to ignore LS initialization on unneeded projects ([lifeart#242](https://github.com/suchitadoshi1987/ember-language-server/issues/242)) ([fc5acf4](fc5acf4))
* add has block params into builtin helper, extended in-repo-addons support ([lifeart#224](https://github.com/suchitadoshi1987/ember-language-server/issues/224)) ([acd71a0](acd71a0))
* add support for multinamespaced components ([lifeart#212](https://github.com/suchitadoshi1987/ember-language-server/issues/212)) ([6b03c83](6b03c83))
* ember-template-lint severity converter (support different severity kinds) ([be3e923](be3e923))
* Improve linting speed & ability to disable default linting ([lifeart#244](https://github.com/suchitadoshi1987/ember-language-server/issues/244)) ([472c0fe](472c0fe))
* improve template-completion caching ([lifeart#248](https://github.com/suchitadoshi1987/ember-language-server/issues/248)) ([afb2d8d](afb2d8d))
* Namespace components (batman syntax) ([2ea63d9](2ea63d9))
* Support `workspace/didChangeConfiguration` event ([lifeart#254](https://github.com/suchitadoshi1987/ember-language-server/issues/254)) ([05d97cb](05d97cb))
* Support jump to definition from parent to child app and tests ([lifeart#234](https://github.com/suchitadoshi1987/ember-language-server/issues/234)) ([24f33e5](24f33e5))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant