Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: improve template-completion caching #248

Merged

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 14, 2021

  • removed glimmer-native support (ping me if smb used it)
  • for vscode implementing fast component complition loigic, based on registry
  • VSCode fs watch api will watch files for changes (and we don't need to reindex project every 10 minutes)

custom file watcher could be implemented in #251

@lifeart lifeart marked this pull request as draft April 14, 2021 21:40
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #248 (10719b6) into component-context-info-origin (8082482) will decrease coverage by 4.91%.
The diff coverage is 62.70%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #248      +/-   ##
=================================================================
- Coverage                          71.63%   66.71%   -4.92%     
=================================================================
  Files                                 17       39      +22     
  Lines                                913     3413    +2500     
  Branches                             180      722     +542     
=================================================================
+ Hits                                 654     2277    +1623     
- Misses                               259     1132     +873     
- Partials                               0        4       +4     
Impacted Files Coverage Δ
src/reference-provider/entry.ts 90.00% <ø> (ø)
...addons/core/code-actions/template-lint-comments.ts 10.76% <10.76%> (ø)
src/template-linter.ts 15.84% <11.11%> (ø)
src/utils/usages-api.ts 29.26% <13.04%> (-70.74%) ⬇️
src/utils/diagnostic.ts 12.50% <14.28%> (-84.06%) ⬇️
...in-addons/core/code-actions/template-lint-fixes.ts 15.00% <15.00%> (ø)
...ddons/core/code-actions/typed-template-comments.ts 15.15% <15.15%> (ø)
src/builtin-addons/core/code-actions/base.ts 20.93% <20.93%> (ø)
.../builtin-addons/core/script-completion-provider.ts 38.61% <25.86%> (ø)
src/code-action-provider/entry.ts 33.33% <33.33%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba3f6...10719b6. Read the comment docs.

@lifeart lifeart changed the title improve template-completion caching feat: improve template-completion caching Apr 15, 2021
@lifeart lifeart marked this pull request as ready for review April 15, 2021 19:37
@lifeart lifeart merged commit afb2d8d into component-context-info-origin Apr 15, 2021
@lifeart lifeart deleted the improve-template-completion-caching branch April 15, 2021 19:43
lifeart pushed a commit that referenced this pull request Apr 15, 2021
# [1.8.0](v1.7.1...v1.8.0) (2021-04-15)

### Features

* improve template-completion caching ([#248](#248)) ([afb2d8d](afb2d8d))
suchitadoshi1987 pushed a commit to suchitadoshi1987/ember-language-server that referenced this pull request Feb 9, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-02-09)

### Bug Fixes

* update debounce implementation ([lifeart#250](https://github.com/suchitadoshi1987/ember-language-server/issues/250)) ([4675e19](4675e19))

### Features

* ability to ignore LS initialization on unneeded projects ([lifeart#242](https://github.com/suchitadoshi1987/ember-language-server/issues/242)) ([fc5acf4](fc5acf4))
* add has block params into builtin helper, extended in-repo-addons support ([lifeart#224](https://github.com/suchitadoshi1987/ember-language-server/issues/224)) ([acd71a0](acd71a0))
* add support for multinamespaced components ([lifeart#212](https://github.com/suchitadoshi1987/ember-language-server/issues/212)) ([6b03c83](6b03c83))
* ember-template-lint severity converter (support different severity kinds) ([be3e923](be3e923))
* Improve linting speed & ability to disable default linting ([lifeart#244](https://github.com/suchitadoshi1987/ember-language-server/issues/244)) ([472c0fe](472c0fe))
* improve template-completion caching ([lifeart#248](https://github.com/suchitadoshi1987/ember-language-server/issues/248)) ([afb2d8d](afb2d8d))
* Namespace components (batman syntax) ([2ea63d9](2ea63d9))
* Support `workspace/didChangeConfiguration` event ([lifeart#254](https://github.com/suchitadoshi1987/ember-language-server/issues/254)) ([05d97cb](05d97cb))
* Support jump to definition from parent to child app and tests ([lifeart#234](https://github.com/suchitadoshi1987/ember-language-server/issues/234)) ([24f33e5](24f33e5))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant