Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use custom file watcher if it's not supported by client #251

Closed
lifeart opened this issue Apr 15, 2021 · 5 comments
Closed

use custom file watcher if it's not supported by client #251

lifeart opened this issue Apr 15, 2021 · 5 comments

Comments

@lifeart
Copy link
Owner

lifeart commented Apr 15, 2021 •
edited
Loading

example - https://github.com/paulmillr/chokidar

likely should be implemented as els-addon first
we should watch for all [js,ts,hbs,css] content of Project.roots except [tmp,dist,vendor,node_modules] folder
@lifeart lifeart mentioned this issue Apr 15, 2021
Merged
@lifeart
Copy link
Owner Author

lifeart commented Apr 15, 2021

related feature: #207

@lifeart
Copy link
Owner Author

lifeart commented May 22, 2021

addon created - https://github.com/lifeart/els-addon-file-watcher

@lifeart
Copy link
Owner Author

lifeart commented May 22, 2021

found thad node_modules appears in project roots, looks like have to debug this logic, and likely we have to exclude els* addons from it

@lifeart
Copy link
Owner Author

lifeart commented May 22, 2021

notification https://github.com/lifeart/ember-language-server/pull/262/files

@lifeart lifeart mentioned this issue May 22, 2021
Closed
@lifeart
Copy link
Owner Author

lifeart commented May 22, 2021

closing this issue, because file-watcher addon created

@lifeart lifeart closed this as completed May 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lifeart