Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: hover provider for intl addon (translations) #340

Merged

Conversation

godric3
Copy link

@godric3 godric3 commented Nov 12, 2021

  1. intl-completion-provider - changed details to documentation to get consistent display of translations in completions and hover:
    image
  2. Hover:
    image

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #340 (49253a4) into component-context-info-origin (c80e15e) will increase coverage by 0.20%.
The diff coverage is 85.45%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #340      +/-   ##
=================================================================
+ Coverage                          70.95%   71.16%   +0.20%     
=================================================================
  Files                                 48       49       +1     
  Lines                               4046     4099      +53     
  Branches                             857      866       +9     
=================================================================
+ Hits                                2871     2917      +46     
- Misses                              1172     1179       +7     
  Partials                               3        3              
Impacted Files Coverage Δ
...rc/builtin-addons/core/intl-completion-provider.ts 100.00% <ø> (+3.33%) ⬆️
src/utils/addon-api.ts 59.87% <ø> (ø)
src/hover-provider/entry.ts 77.27% <76.47%> (-6.07%) ⬇️
src/builtin-addons/core/intl-hover-provider.ts 100.00% <100.00%> (ø)
src/utils/builtin-addons-initializer.ts 94.11% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1ac21...49253a4. Read the comment docs.

src/builtin-addons/core/intl-hover-provider.ts Outdated Show resolved Hide resolved
src/hover-provider/entry.ts Show resolved Hide resolved
@lifeart lifeart changed the title translations hover for intl feat: hover provider for intl addon (translations) Nov 12, 2021
@lifeart lifeart merged commit 3a7e6d0 into lifeart:component-context-info-origin Nov 12, 2021
@lifeart
Copy link
Owner

lifeart commented Nov 12, 2021

@godric3 thank you for contribution!

Could you provide your opinion on #335?

We need to figure-out:

  • namespaced file support
  • custom translation location
  • limit for translations to show (5 - 10?)
  • kinda "translation" or service, to include it to complete/definition/hover provider to cache tanslation results, and detect changes, using Project change file api

lifeart pushed a commit that referenced this pull request Nov 12, 2021
# [2.6.0](v2.5.1...v2.6.0) (2021-11-12)

### Features

* hover provider for intl addon (translations) ([#340](#340)) ([3a7e6d0](3a7e6d0))
@lifeart
Copy link
Owner

lifeart commented Nov 12, 2021

uELS 3.0.10 published https://twitter.com/vaier/status/1459227487855165445

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants