Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: change the explorer link for bitcoin #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

myz1237
Copy link
Collaborator

@myz1237 myz1237 commented Nov 4, 2024

No description provided.

@myz1237
Copy link
Collaborator Author

myz1237 commented Nov 5, 2024

@myz1237 myz1237 requested a review from chybisov November 5, 2024 13:15
Copy link
Member

@chybisov chybisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myz1237 I intentionally changed it mempool to be the first block explorer for Bitcoin because it is better and widely used in the ecosystem. Why did we decided to change it back?

@myz1237
Copy link
Collaborator Author

myz1237 commented Jan 22, 2025

@chybisov that's how we generate bitcoin explorer in our backend:
image
I wanna unify it to use chain.metamask.blockExplorerUrls[0] + 'tx/' + txHash

@chybisov
Copy link
Member

@chybisov that's how we generate bitcoin explorer in our backend: image I wanna unify it to use chain.metamask.blockExplorerUrls[0] + 'tx/' + txHash

Both blockchair and mempool support this format:

https://mempool.space/tx/7898d4a8e9cc98a3318873bd3fd1ce731de63cdadf9d85868ac65bcf7d4effcc
https://blockchair.com/bitcoin/tx/7898d4a8e9cc98a3318873bd3fd1ce731de63cdadf9d85868ac65bcf7d4effcc

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants