Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for Symfony 4.1 #73

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Support for Symfony 4.1 #73

merged 2 commits into from
Nov 13, 2019

Conversation

Enc3phale
Copy link
Contributor

@Enc3phale Enc3phale commented Jul 16, 2018 •
edited
Loading

Updates to support Symfony 4.1:

  • Use native Twig references for templates, this makes the template compatible with recent Symfony versions.
  • Correct controllers references to remove deprecations with Symfony 4.1

All tested and works good with SF 2.7, SF 3.0 and SF 4.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.758% when pulling bd62c6a on Webmecanik:master into b1c53da on lightSAML:master.

@frostieDE frostieDE mentioned this pull request Jul 18, 2018
Closed
@jon92
Copy link

jon92 commented Oct 25, 2018

Hello,
Is it going to be merged ? I forked the project to include the fix for 4.1 but I would prefer to keep using your bundle.

Thanks

@iambrosi
Copy link

iambrosi commented Nov 8, 2018

I'm also interested in seeing this PR merged.

@iambrosi
Copy link

@tmilos any news on this?

@tmilos tmilos merged commit 2150175 into lightSAML:master Nov 13, 2019
@tmilos
Copy link
Member

tmilos commented Nov 13, 2019

Released in 1.2.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Enc3phale @coveralls @jon92 @iambrosi @tmilos