Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update alert icon #214

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Update alert icon #214

merged 3 commits into from
Jun 2, 2021

Conversation

BRHGreen
Copy link
Contributor

Proposed changes

I got confirmation from Danielle that we're going with the circular alert icon across the board. However I am stiil having trouble getting it to behave in the same way that all the other icons do. The issue is that there appears to be some white space actually included in the svg and I can't figure out how to remove it.

Types of changes

What types of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please use the following checklist before contributing to this repository.

  • I have added tests that prove my fix is effective or that my feature works
  • I have implemented error checking and considered data not being available or loading
  • I have added necessary documentation (if appropriate)
  • I have implemented correct type checking
  • I have tested my changes on a mobile layout
  • I have double checked with the team that I haven't introduced duplicates in functionalities (components, services, database changes, etc...)
  • If required, designers have signed off my changes
  • I have communicated the changes to the QA team and planned testing
  • I have implemented e2e tests for the new functionality

@BRHGreen BRHGreen requested a review from josephrace May 28, 2021 11:59
@josephrace
Copy link
Contributor

josephrace commented Jun 1, 2021

@BRHGreen I've pushed a change for the icon so should be ok now. I noticed that we're losing consistency across some of the icons in the Sketch file so we should probably have a session with the designers to review this at some point (as we discussed).

@josephrace
Copy link
Contributor

p.s. I would probably release this as a patch

@BRHGreen
Copy link
Contributor Author

BRHGreen commented Jun 2, 2021

@BRHGreen I've pushed a change for the icon so should be ok now. I noticed that we're losing consistency across some of the icons in the Sketch file so we should probably have a session with the designers to review this at some point (as we discussed).

Great. i think that it'd be good for me ( and maybe Thomas. Maybe he already knows this stuff?) to know what to look out for as well. I could tell Danielle that it didn't look right but I couldn't tell her exactly why.

@josephrace josephrace merged commit 5236d46 into main Jun 2, 2021
@josephrace josephrace deleted the warning-circle-icon branch June 2, 2021 12:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants