Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add icon save #218

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Add icon save #218

merged 4 commits into from
Jun 21, 2021

Conversation

ThomasPalamara
Copy link
Contributor

Proposed changes

Please describe the big picture of your changes here to communicate why we should introduce these changes.

Types of changes

What types of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please use the following checklist before contributing to this repository.

  • I have added tests that prove my fix is effective or that my feature works
  • I have implemented error checking and considered data not being available or loading
  • I have added necessary documentation (if appropriate)
  • I have implemented correct type checking
  • I have tested my changes on a mobile layout
  • I have double checked with the team that I haven't introduced duplicates in functionalities (components, services, database changes, etc...)
  • If required, designers have signed off my changes
  • I have communicated the changes to the QA team and planned testing
  • I have implemented e2e tests for the new functionality

@ThomasPalamara ThomasPalamara merged commit 53b419d into main Jun 21, 2021
@ThomasPalamara ThomasPalamara deleted the add-icon-save branch June 21, 2021 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants