Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade react select #220

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Upgrade react select #220

merged 2 commits into from
Jun 28, 2021

Conversation

BRHGreen
Copy link
Contributor

Proposed changes

Update react select so as to remove it's dependancy and dom-helpers

Types of changes

What types of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please use the following checklist before contributing to this repository.

  • I have added tests that prove my fix is effective or that my feature works
  • I have implemented error checking and considered data not being available or loading
  • I have added necessary documentation (if appropriate)
  • I have implemented correct type checking
  • I have tested my changes on a mobile layout
  • I have double checked with the team that I haven't introduced duplicates in functionalities (components, services, database changes, etc...)
  • If required, designers have signed off my changes
  • I have communicated the changes to the QA team and planned testing
  • I have implemented e2e tests for the new functionality

@BRHGreen BRHGreen requested a review from josephrace June 28, 2021 09:09
Copy link
Contributor

@josephrace josephrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BRHGreen BRHGreen merged commit 0118b6c into main Jun 28, 2021
@BRHGreen BRHGreen deleted the update-react-select branch June 28, 2021 13:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants