Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PLATFORM-3404 - Allow Alert display type to be overwritten #289

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

woodyblah
Copy link
Contributor

Proposed changes

The Alert container has the class d-flex hardcoded, this PR allows it to be overwritten while keeping the d-flex as the default to allow backwards compatibility.

Types of changes

What types of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please use the following checklist before contributing to this repository.

  • I have added tests that prove my fix is effective or that my feature works
  • I have implemented error checking and considered data not being available or loading
  • I have added necessary documentation (if appropriate)
  • I have implemented correct type checking
  • I have tested my changes on a mobile layout
  • I have double checked with the team that I haven't introduced duplicates in functionalities (components, services, database changes, etc...)
  • If required, designers have signed off my changes
  • I have communicated the changes to the QA team and planned testing
  • I have implemented e2e tests for the new functionality

@woodyblah woodyblah merged commit f9dc358 into main Oct 5, 2023
@woodyblah woodyblah deleted the PLATFORM-3404-allow-alert-display-to-be-changed branch October 5, 2023 10:08
woodyblah added a commit that referenced this pull request Oct 5, 2023
* Allow Alert display to be changed

* Update version number
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants