Remove requirements to disconnect on warnings #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generally shouldn't disconnect when sending or receiving warning messages. Whenever disconnecting after a warning makes sense, it should be specified in the requirements linked to that specific scenario. Fixes lightning#1072
28 tasks
vincenzopalazzo
approved these changes
May 5, 2023
TheBlueMatt
approved these changes
May 6, 2023
|
@Roasbeef can someone from LL ACK this and check lnd's behavior, which seems to disconnect when receiving a warning message? |
|
As far as I can tell, since Let me just double confirm this & will get back with an ACK. But defs a concept ACK from me. |
Roasbeef
approved these changes
May 9, 2023
Roasbeef
approved these changes
May 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generally shouldn't disconnect when sending or receiving warning messages. Whenever disconnecting after a warning makes sense, it should be specified in the requirements linked to that specific scenario.
Fixes #1072