BOLT #7: Make channel_update always have htlc_maximum_msat. #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
ACK 466317a |
TheBlueMatt
approved these changes
May 31, 2022
Roasbeef
approved these changes
May 31, 2022
vincenzopalazzo
approved these changes
May 31, 2022
t-bast
reviewed
May 31, 2022
Suggested-by: @t-bast Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
t-bast
previously approved these changes
Jun 1, 2022
|
As noted in lightningdevkit/rust-lightning#1515 and discussed during the dev summit, it would also make sense to verify that every implementation sets this value to |
|
Retracting my ACK, I made a proposal at #999 that would benefit from message flags (but I did make |
24 tasks
vincenzopalazzo
approved these changes
Jun 18, 2022
24 tasks
3 tasks
|
I have just downloaded a fresh batch of 134k channel updates from an LND peer; of those channel updates, 364 don't have an HTLC max set, which is 0.27%. I have separately downloaded 161k updates from a different peer, and got 399 instances of an unset HTLC max, or 0.25%. |
25 tasks
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 3, 2022
The specification is removing support for old channel updates that didn't include an `htlc_maximum_msat` (lightning/bolts#996). Every implementation has been generating updates containing this field for years, so we can safely reject updates that don't contain it.
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 3, 2022
The specification is removing support for old channel updates that didn't include an `htlc_maximum_msat` (lightning/bolts#996). Every implementation has been generating updates containing this field for years, so we can safely reject updates that don't contain it.
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 3, 2022
The specification is removing support for old channel updates that didn't include an `htlc_maximum_msat` (lightning/bolts#996). Every implementation has been generating updates containing this field for years, so we can safely reject updates that don't contain it.
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 8, 2022
The specification is removing support for old channel updates that didn't include an `htlc_maximum_msat` (lightning/bolts#996). Every implementation has been generating updates containing this field for years, so we can safely reject updates that don't contain it.
25 tasks
|
Replaced by #999 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think everyone sets this. Vastly simplifies parsing.
Indeed, every single of the 149964 channel updates seen by my node has his set.