Skip to content

Rename PendingHTLCInfo fields to include msat suffix #1844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

valentinewallace
Copy link
Contributor

Addresses #1840 (comment)

@codecov-commenter
Copy link

Codecov Report

Base: 90.79% // Head: 90.79% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (246d33d) compared to base (d036400).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   90.79%   90.79%   -0.01%     
==========================================
  Files          89       89              
  Lines       47975    47975              
  Branches    47975    47975              
==========================================
- Hits        43561    43560       -1     
- Misses       4414     4415       +1     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 85.38% <100.00%> (-0.03%) ⬇️
lightning/src/ln/onion_route_tests.rs 97.58% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.02%) ⬇️
lightning-net-tokio/src/lib.rs 77.03% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants