Add lnurl fallback support to sender vasp #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
reviewed
Feb 8, 2024
| val lnurlpResponse = try { | ||
| response.body<NonUmaLnurlpResponse>() | ||
| } catch (e: Exception) { | ||
| call.application.environment.log.error("Failed to parse as non UMA lnurlp response\n${response.bodyAsText()}", e) |
There was a problem hiding this comment.
At this point, we've failed to parse as both uma and non-uma. Maybe we should log that in the response? Might also be good to log the uma parsing error above for debugging purposes.
|
|
||
| val newCallbackId = requestDataCache.savePayReqData( | ||
| encodedInvoice = payReqResponse.pr, | ||
| utxoCallback = getUtxoCallback(call, "1234abc"), |
There was a problem hiding this comment.
This utxo callback should actually always be empty in the case of non-uma lnurl.
jklein24
approved these changes
Feb 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards LIG-4111