adding sending / receiving vasp methods for demo #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matthappens and the rest of your teammates on |
jklein24
reviewed
Sep 4, 2024
| @@ -38,7 +38,7 @@ import me.uma.protocol.createCounterPartyDataOptions | |||
| import me.uma.protocol.createPayeeData | |||
| import me.uma.protocol.identifier | |||
|
|
|||
| class Vasp2( | |||
| class ReceivingVasp( | |||
| call.debugLog(sendingVasp.payInvoice(call)) | ||
| } | ||
|
|
||
| post("/api/uma/request_and_pay_invoice") { |
There was a problem hiding this comment.
I think this should really be request_invoice_payment or something. It's not actually paying the invoice, but rather, just sending a notification to the user for them to trigger a payment. Feel free to find a name you think fits better. Would be good to align all of the demo vasps with the same routes.
This was referenced Sep 9, 2024
jklein24
approved these changes
Sep 9, 2024
jklein24
approved these changes
Sep 10, 2024
matthappens
force-pushed
the
09-03-adding_sending___receiving_vasp_methods_for_demo
branch
from
e71c36c to
9817cd7
Compare
matthappens
deleted the
09-03-adding_sending___receiving_vasp_methods_for_demo
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit - rename vasp1 & vasp 2 to sending/receiving vasp, add skeleton methods for new routes