Skip to content

Bump sdk version, use standard errors in UMA demo vasp #226

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

shreyav
Copy link
Contributor

@shreyav shreyav commented Mar 21, 2025

No description provided.

Verified

This commit was signed with the committer’s verified signature.
adangel Andreas Dangel
Copy link
Contributor Author

shreyav commented Mar 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

return "failed to fetch $wellKnownConfiguration"
throw UmaException(
"failed to fetch request / pay endpoint at $wellKnownConfiguration",
ErrorCode.INTERNAL_ERROR,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be its own code, will address it a followup

"failed to fetch request / pay endpoint at $wellKnownConfiguration",
ErrorCode.INTERNAL_ERROR,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as below

@shreyav shreyav marked this pull request as ready for review March 21, 2025 18:31
Copy link
Contributor

@JasonCWang JasonCWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceu!

@shreyav shreyav merged commit 98a9dd8 into develop Mar 21, 2025
2 checks passed
@shreyav shreyav deleted the 03-21-bump_sdk_version_use_standard_errors_in_uma_demo_vasp branch March 21, 2025 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants